fix: array to array cast #2897
Open
fix: array to array cast #2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuzhang
force-pushed
the
test-array-cast
branch
4 times, most recently
from
864a25f to
92a7867
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2897 +/- ##
============================================
+ Coverage 56.12% 59.53% +3.40%
- Complexity 976 1376 +400
============================================
Files 119 167 +48
Lines 11743 15496 +3753
Branches 2251 2569 +318
============================================
+ Hits 6591 9225 +2634
- Misses 4012 4971 +959
- Partials 1140 1300 +160 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Created #2914 for the failed test |
Member
Author
|
Submitted #2916 to fix the failed test. |
manuzhang
force-pushed
the
test-array-cast
branch
from
92a7867 to
5f7b017
Compare
| Ok(cast_with_options(&array, to_type, &CAST_OPTIONS)?) | ||
| (List(from), List(to)) | ||
| if can_cast_types(from_type, to_type) | ||
| || (matches!(from.data_type(), Decimal128(_, _)) |
Contributor
There was a problem hiding this comment.
Is this the only case where we have a spark cast but no DF/arrow cast?
coderfender
reviewed
Jan 10, 2026
| } | ||
|
|
||
| private def generateArrays(rowSize: Int, elementType: DataType): DataFrame = { | ||
| private def generateArrays(rowNum: Int, elementType: DataType): DataFrame = { |
Contributor
There was a problem hiding this comment.
nit : might be an unintended change ?
Member
Author
There was a problem hiding this comment.
This is intended since rowNum (meaning the number of rows) makes more sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2766
Rationale for this change
What changes are included in this PR?
How are these changes tested?
Added tests.